Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Allow to use own cdn or include jquery file #77

Open
Shnoulle opened this issue Oct 31, 2019 · 3 comments
Open

[feature] Allow to use own cdn or include jquery file #77

Shnoulle opened this issue Oct 31, 2019 · 3 comments

Comments

@Shnoulle
Copy link

Currntly : there are a call to ajax.googleapis.com for jquery. Some user disable all google call and then they can not have the working JS

2 solutions

  1. Add jquery (min) file in the repo
  2. Create a $_CONFIG to load another cdn (can be an user link)
@marekrei
Copy link
Owner

marekrei commented Nov 4, 2019

I think most users would prefer to link the public javascript file. Those who want to use their own can just change the URL on line 2969. I don't think it's enough of a common case to create a separate config option.

@Merith-TK
Copy link

I personally just wget the js file, and stored it on my server and then changed the link

So basically i hid the cdn.example.com/.js folder, and changed the path to the js file to cdn.example.com/.js/jquery.min.js

@Shnoulle
Copy link
Author

I update too the url : i's easy :). But maybe it can be easiest to have a $_CONFIG then ?

SamantazFox added a commit to SamantazFox/encode-explorer that referenced this issue Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants