-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test_id param to test types #79
base: master
Are you sure you want to change the base?
Conversation
I am actively working on subtle changes to the scripts as part of implementing CheckList at Expedia. I am happy to submit more PR for these features that I am adding. If not, I will just keep them in my fork. Let me know. |
I thought about having a unique identifier when I first wrote this, and decided at that time that the test name was probably going to be unique enough. Could you elaborate as to why you felt the need for an ID? Thanks : ) |
Did you by any chance consider using |
Oh yeah, I am using custom test suite - inherited from |
A note on serializing test suites: |
In addition to
test_name
anddescription
, a unique test identifier is often assigned to quickly identify different test cases. To enable this, I have added a new optionaltest_id
keyword argument toabstract_test
as well asMFT, DIR, INV
classes. Also, I created atests
directory with unit tests that checks if object creation succeeds with and without this new argument. Please merge if you feel this could be useful.