Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: change replaceAll to replace for NodeJS 14 compatibility #133

Closed
marco-prontera opened this issue Jan 28, 2024 · 0 comments · Fixed by #132
Closed

[Bug]: change replaceAll to replace for NodeJS 14 compatibility #133

marco-prontera opened this issue Jan 28, 2024 · 0 comments · Fixed by #132
Assignees
@marco-prontera
Labels
bug Something isn't working

Comments

@marco-prontera
Copy link
Owner

🐞 Bug Report

Describe the bug

  • replaceAll not compatible with NodeJS 14
@marco-prontera marco-prontera added the bug Something isn't working label Jan 28, 2024
@marco-prontera marco-prontera self-assigned this Jan 28, 2024
@marco-prontera marco-prontera linked a pull request Jan 28, 2024 that will close this issue
[#133] change replaceAll to replace for NodeJS 14 compatibility #132
Merged
marco-prontera pushed a commit that referenced this issue Jan 28, 2024
@drbeat
[#133] change replaceAll to replace for NodeJS 14 compatibility (#132)
df64f5f 
replaceAll is available from Nodejs 15+
But the regex here works also with replace which also guarantees nodejs 14 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-prontera marco-prontera

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@marco-prontera