From db10fa43b1578a6bac873aeb22f5cb882405e3da Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Thu, 16 Nov 2023 00:48:52 +0000 Subject: [PATCH] Bug 1862032 [wpt PR 42811] - Revert recent changes to inheritance of direction and language for elements., a=testonly Automatic update from web-platform-tests Revert recent changes to inheritance of direction and language for elements. (#42811) This changes the way elements inherit the HTML concepts of direction and language to inherit from their parent, rather than from their shadow root's host. This matches the changes that I'm proposing in: https://github.com/whatwg/html/pull/9880 These changes are all behind flags that are slated to ship in M120: CSSPseudoDir for the direction changes and HTMLLangNewInheritance for the language changes. Bug: 576815, 1490711 Change-Id: I152d8e21e24e77c9359744019b3ab875c2a21727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4984312 Reviewed-by: Di Zhang Commit-Queue: David Baron Cr-Commit-Position: refs/heads/main{#1216286} Co-authored-by: L. David Baron -- wpt-commits: e873a33f5a8564beb3864cb779e0c774aa4816c7 wpt-pr: 42811 UltraBlame original commit: 741c58ae49f75723489b635e662f1fa8caf9a341 --- .../global-attributes/dir-shadow-35-ref.html | 4 ++-- .../elements/global-attributes/dir-shadow-35.html | 2 +- .../global-attributes/dir-shadow-41-ref.html | 13 ++++--------- .../elements/global-attributes/dir-shadow-41.html | 14 +++++++------- .../lang-attribute-shadow.window.js | 5 ++--- 5 files changed, 16 insertions(+), 22 deletions(-) diff --git a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35-ref.html b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35-ref.html index 8b9f8bf7b0970..09f3fcc795306 100644 --- a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35-ref.html +++ b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35-ref.html @@ -295,10 +295,10 @@ value for the -span +slot is : -rtl +ltr / ltr . diff --git a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35.html b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35.html index c8f11ebfc163b..0745437e77ca0 100644 --- a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35.html +++ b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-35.html @@ -320,7 +320,7 @@ value for the -span +slot is : < diff --git a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41-ref.html b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41-ref.html index 0c640d9258d83..54b9adcf7b419 100644 --- a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41-ref.html +++ b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41-ref.html @@ -233,7 +233,7 @@ > dir = -ltr +rtl on a div @@ -243,7 +243,7 @@ tree dir = -rtl +ltr on the shadow @@ -271,7 +271,7 @@ dir = " -rtl +ltr " > < @@ -279,16 +279,11 @@ dir = " -ltr +rtl " > < span -dir -= -" -rtl -" > < / diff --git a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41.html b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41.html index f9c7c041b5de9..c9ee31bc58d78 100644 --- a/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41.html +++ b/testing/web-platform/tests/html/dom/elements/global-attributes/dir-shadow-41.html @@ -272,7 +272,7 @@ > dir = -ltr +rtl on a div @@ -282,7 +282,7 @@ tree dir = -rtl +ltr on the shadow @@ -310,7 +310,7 @@ dir = " -rtl +ltr " > < @@ -386,7 +386,7 @@ dir = " -ltr +rtl " > < @@ -427,7 +427,7 @@ [ dir = -ltr +rtl ] " ) @@ -450,7 +450,7 @@ [ dir = -ltr +rtl ] " ) @@ -475,7 +475,7 @@ [ dir = -ltr +rtl ] " ) diff --git a/testing/web-platform/tests/html/dom/elements/global-attributes/lang-attribute-shadow.window.js b/testing/web-platform/tests/html/dom/elements/global-attributes/lang-attribute-shadow.window.js index e1e6e20e7623c..191ef5bd33e23 100644 --- a/testing/web-platform/tests/html/dom/elements/global-attributes/lang-attribute-shadow.window.js +++ b/testing/web-platform/tests/html/dom/elements/global-attributes/lang-attribute-shadow.window.js @@ -416,8 +416,7 @@ on slot inherits from -shadow -host +parent " light_tree : @@ -502,7 +501,7 @@ expected " en - -GB +CA " > <