From 6453d14f56410a9ed704343f511b0b7460a887ba Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Fri, 23 Aug 2024 04:37:47 +0000 Subject: [PATCH] Bug 1909293 [wpt PR 47237] - DOM: Rename EventTarget#on() to EventTarget#when(), a=testonly Automatic update from web-platform-tests DOM: Rename EventTarget#on() to EventTarget#when() See the discussion in https://github.com/WICG/observable/issues/39, which led to this decision, and https://github.com/WICG/observable/pull/161 for the corresponding spec rename. R=jarhar Bug: 40282760 Change-Id: I9cd744460a3545c74fb34a0418c6ffddc5e6d4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5730072 Reviewed-by: Joey Arhar Commit-Queue: Dominic Farolino Cr-Commit-Position: refs/heads/main{#1340875} -- wpt-commits: c4e3d193ad0d0e708ad2f252a245c368df098c6e wpt-pr: 47237 UltraBlame original commit: 635103775408664b51f70080db91b67ba60941b8 --- .../observable-constructor.window.js | 2 +- .../tentative/observable-event-target.any.js | 20 ++++++++++--------- .../observable-event-target.window.js | 6 +++--- .../tentative/observable-from.any.js | 2 +- .../tentative/observable-inspect.any.js | 2 +- 5 files changed, 17 insertions(+), 15 deletions(-) diff --git a/testing/web-platform/tests/dom/observable/tentative/observable-constructor.window.js b/testing/web-platform/tests/dom/observable/tentative/observable-constructor.window.js index 45e273b1b01b4..166509d1f3680 100644 --- a/testing/web-platform/tests/dom/observable/tentative/observable-constructor.window.js +++ b/testing/web-platform/tests/dom/observable/tentative/observable-constructor.window.js @@ -875,7 +875,7 @@ source = event_target . -on +when ( ' customevent diff --git a/testing/web-platform/tests/dom/observable/tentative/observable-event-target.any.js b/testing/web-platform/tests/dom/observable/tentative/observable-event-target.any.js index 14c96bb475df7..61cb3d0345770 100644 --- a/testing/web-platform/tests/dom/observable/tentative/observable-event-target.any.js +++ b/testing/web-platform/tests/dom/observable/tentative/observable-event-target.any.js @@ -17,14 +17,14 @@ assert_implements ( target . -on +when " The EventTarget interface has an -on +when method " ) @@ -34,7 +34,7 @@ assert_equals typeof target . -on +when " function " @@ -43,7 +43,7 @@ EventTarget should have the -on +when method " ) @@ -53,7 +53,7 @@ testEvents = target . -on +when ( " test @@ -68,7 +68,9 @@ Observable " EventTarget . -on +when +( +) returns an Observable @@ -192,7 +194,7 @@ event " EventTarget . -on +when ( ) returns @@ -221,7 +223,7 @@ testEvents = target . -on +when ( " test @@ -446,7 +448,7 @@ testEvents = target . -on +when ( " test diff --git a/testing/web-platform/tests/dom/observable/tentative/observable-event-target.window.js b/testing/web-platform/tests/dom/observable/tentative/observable-event-target.window.js index b8c6415943bc6..65a58a65d56bc 100644 --- a/testing/web-platform/tests/dom/observable/tentative/observable-event-target.window.js +++ b/testing/web-platform/tests/dom/observable/tentative/observable-event-target.window.js @@ -104,7 +104,7 @@ captureObservable = body . -on +when ( ' click @@ -121,7 +121,7 @@ bubbleObservable = body . -on +when ( ' click @@ -237,7 +237,7 @@ observable = target . -on +when ( ' event diff --git a/testing/web-platform/tests/dom/observable/tentative/observable-from.any.js b/testing/web-platform/tests/dom/observable/tentative/observable-from.any.js index a7a686f50b1a7..58c4cdd2a7e02 100644 --- a/testing/web-platform/tests/dom/observable/tentative/observable-from.any.js +++ b/testing/web-platform/tests/dom/observable/tentative/observable-from.any.js @@ -256,7 +256,7 @@ observable = target . -on +when ( ' custom diff --git a/testing/web-platform/tests/dom/observable/tentative/observable-inspect.any.js b/testing/web-platform/tests/dom/observable/tentative/observable-inspect.any.js index edd236a321abe..0624065d2c42a 100644 --- a/testing/web-platform/tests/dom/observable/tentative/observable-inspect.any.js +++ b/testing/web-platform/tests/dom/observable/tentative/observable-inspect.any.js @@ -2769,7 +2769,7 @@ AbortController ; self . -on +when ( ' error