From 25f1a30cc1de85256ae8a37afe9013cb8a10d185 Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Thu, 30 Nov 2023 16:14:24 +0000 Subject: [PATCH] Bug 1865927 [wpt PR 43295] - DOM: Introduce SubscribeOptions for Observable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See https://github.com/WICG/observable/pull/85 and https://github.com/WICG/observable/issues/71 for any relevant design discussion. R=masonfchromium.org Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino Reviewed-by: Mason Freed Cr-Commit-Position: refs/heads/main{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295 UltraBlame original commit: 4e0693e5004ddbf96ffd35d00ffd72526b384f90 --- .../tentative/observable-constructor.any.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/testing/web-platform/tests/dom/observable/tentative/observable-constructor.any.js b/testing/web-platform/tests/dom/observable/tentative/observable-constructor.any.js index 73bf946872ea..ced820fb244e 100644 --- a/testing/web-platform/tests/dom/observable/tentative/observable-constructor.any.js +++ b/testing/web-platform/tests/dom/observable/tentative/observable-constructor.any.js @@ -1165,6 +1165,8 @@ source subscribe ( { +} +{ signal : AbortSignal @@ -1255,6 +1257,8 @@ source subscribe ( { +} +{ signal : controller @@ -3791,6 +3795,8 @@ complete ) ' ) +} +{ signal : ac @@ -4058,6 +4064,8 @@ push complete ' ) +} +{ signal : ac @@ -4534,6 +4542,8 @@ source subscribe ( { +} +{ signal : ac @@ -5487,6 +5497,8 @@ push complete ' ) +} +{ signal : ac