Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Devices #3

Open
scinfu opened this issue Mar 17, 2016 · 4 comments
Open

New Devices #3

scinfu opened this issue Mar 17, 2016 · 4 comments

Comments

@scinfu
Copy link

scinfu commented Mar 17, 2016

Can you update with new devices ?

Thank you
@marchv
Copy link
Owner

marchv commented Mar 17, 2016

Hi scinfo and thanks for your interest!

I will try to look into this at some point. But since I made this framework the Apple introduced Zoom-mode on iPhone 6 and later. I think this challenges this relatively simple solution...

Cheers!

@scinfu
Copy link
Author

scinfu commented Apr 12, 2016

I added new iPad Pro 9.7 and 12.9 #4

With last update i think you have write wrong values , like iPhone 6 plus , ppi are 401.0f but i this the rignt value is 200.5 . 401 is in ddp .

@marchv
Copy link
Owner

marchv commented Oct 3, 2017

Hi @scinfu :) I know it has been a while but I have just reimplemented this for Swift (as a pod), please checkout https://github.com/marchv/UIScreenExtension. I might also introduce support for ObjC too. The new implementation should also take care of zoom mode. Cheers!

@scinfu
Copy link
Author

scinfu commented Oct 3, 2017

Nice, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scinfu @marchv