diff --git a/Product.md b/Product.md index 9676b1a..735f45d 100644 --- a/Product.md +++ b/Product.md @@ -75,6 +75,11 @@ In the DECAC: session.CustomActionData["mister"] THIS WILL CRASH +### Enforce feature installation (e.g. REMOVE_CONFIG not writtten to registry) + + 1 + + ### Conditional removal of lifetime data "Lifetime data" means any change that was not installed by the msi (during the life time of the application). diff --git a/Product.wxs b/Product.wxs index 23908c0..081497f 100644 --- a/Product.wxs +++ b/Product.wxs @@ -13,13 +13,11 @@ - + not VersionNT64 Installed or (not AbortReason) - - Installed OR (MsiNTProductType = 1) AND (VersionNT >= 601) @@ -27,10 +25,8 @@ OR (MsiNTProductType = 3) AND (VersionNT >= 602) Installed OR (PhysicalMemory > 125) - Privileged - Installed OR (CONFIG_TYPE = "Existing") @@ -48,21 +44,22 @@ OR (NSIS_DISPLAYVERSION << "20") OR (NSIS_DISPLAYVERSION << "30") OR NOT NSIS_DISPLAYVERSION) OR Installed]]> - NOT (NSIS_UNINSTALLSTRING >> "uninst.exe") - + @@ -117,7 +114,7 @@ Root="HKLM" Key="SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Salt Minion" Name="DisplayVersion" Type="raw" Win64="no" /> - + NSIS_UNINSTALLSTRING >> "uninst.exe" @@ -128,38 +125,61 @@ objShell.Run "net stop salt-minion", 0, true objShell.Run "cmd /c ping -n 5 127.0.0.1", 0, True - + + NOT Installed - + + + - 1 + 1 - NOT Installed - nsis_exe + NOT Installed + nsis_exe NOT Installed - NOT Installed + Before='WriteConfig_DECAC' >NOT Installed + NOT Installed REMOVE ~= "ALL" - REMOVE ~= "ALL" + Before='DeleteConfig_DECAC' >REMOVE ~= "ALL" + REMOVE ~= "ALL" + + + - + @@ -196,6 +216,7 @@ objShell.Run "cmd /c ping -n 5 127.0.0.1", 0, True + @@ -261,7 +282,7 @@ objShell.Run "cmd /c ping -n 5 127.0.0.1", 0, True - + @@ -289,9 +310,8 @@ objShell.Run "cmd /c ping -n 5 127.0.0.1", 0, True - not MOVE_CONF - not MOVE_CONF - + not MOVE_CONF + not MOVE_CONF @@ -306,8 +326,7 @@ objShell.Run "cmd /c ping -n 5 127.0.0.1", 0, True - - + diff --git a/test_dirs_reg_service.cmd b/test_dirs_reg_service.cmd new file mode 100644 index 0000000..18eecad --- /dev/null +++ b/test_dirs_reg_service.cmd @@ -0,0 +1,20 @@ +@echo off +IF exist "c:\salt\conf" ( +echo "c:\salt\conf" +dir /b /s "c:\salt\conf" ) + +IF exist "C:\ProgramData\Salt Project\salt\conf" ( +echo "C:\ProgramData\Salt Project\salt\conf" +dir /b "C:\ProgramData\Salt Project\salt\conf" ) + +IF exist "C:\Program Files (x86)\Salt Project\salt" ( +echo "C:\Program Files (x86)\Salt Project\salt" +dir /b "C:\Program Files (x86)\Salt Project\salt" ) + +IF exist "C:\Program Files\Salt Project\salt" ( +echo "C:\Program Files\Salt Project\salt" +dir /b "C:\Program Files\Salt Project\salt" ) + +Reg Query "HKLM\SOFTWARE\Salt Project\salt" + +sc query salt-minion diff --git a/uninstall.cmd b/uninstall.cmd index 14cce78..f26f5c0 100644 --- a/uninstall.cmd +++ b/uninstall.cmd @@ -1 +1 @@ -msiexec /x %1 /qb! /l*v %1-uninstall.log +msiexec /x %* /qb! /l*v %1-uninstall.log