tests: migrate to insta binary snapshots #1616
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates us to insta's binary snapshots.
These snapshots were added via
Currently, this PR is not mergable as the binary snapshots don't actually work. I encountered these two bugs:
FILENAME.snap.new.png
. This naming is inconsistent with how other snapshots are created.cargo test
andcargo insta
still provide really weird results=> to be mergable, this PR would need work upstream.
I am going to try to write this up during the christmas holidays and provide a fix upstream.