Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validations to .mbtiles detection #741

Open
2 tasks
nyurik opened this issue Jul 3, 2023 · 0 comments
Open
2 tasks

Add more validations to .mbtiles detection #741

nyurik opened this issue Jul 3, 2023 · 0 comments
Labels
good first issue help wanted mbtiles Anything related to Martin's MBTiles support

Comments

@nyurik
Copy link
Member

nyurik commented Jul 3, 2023

As part of mbtiles type detection, we should catch some common issues:

  • detect if tiles (simple) or map (deduplicated) tables have an index by z,x,y columns
  • ???

In case of a problem, use a warn! macro to print a warning, unless we are certain the issue makes it impossible to use a file, in which case it should be appropriate error (add it to the error enum).

A bigger discussion is if mbtiles should stop using logging, and return some Vec<MbtilesWarning> if non-critical issues are detected.

@nyurik nyurik added help wanted good first issue mbtiles Anything related to Martin's MBTiles support labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted mbtiles Anything related to Martin's MBTiles support
Projects
None yet
Development

No branches or pull requests

1 participant