-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace webpack with Vite #803
Comments
Disclaimer: I'm not maintaining this project. I've tried to introduce some typescript migration ability in webpack and it was frustrating to say the least. So if this can be a way forward maybe a joint effort here can be a good idea, what do you think? P.S. just saw that this issue is from Feb :-/ |
Hey @HarelM!
I'd say it's one of the reasons Vite became so popular – just add
Could you see if adding
I agree, just one question, do we know if such a migration would be merged? |
It does help, but it seems like an intermidiate hack, and I don't like it...
You can see the comment in #828 I also did some experimentation with I would recommend opening a PR just for vite and see how it goes, after that we can see how we can upgrade the dev dependencies and introduce typescript. I can reach out to the maintainers to give us contributor roles in needed and if this is something you would like to maintain going forward. |
I have opened a PR with changes that are very similar to what is linked here. |
Resolves #803 This is an initial commit to allow migrating to typescript bit by bit. It introduces vite. It removes all the webpack configuration (which I have no clue what all the profiling are needed for, and couldn't find anything in the readme). It also changes a single file from javascript to typescript: `urlopen.js` -> `urlopen.ts` Which was done manually, later on I'll see if I can automate most of the migration. For now, everything seems to work as expected. I also upgrades storybook to use vite and renames the stories to jsx (I honestly don't know why this complexity is needed here, but I'll keep it for now). cc: @damianstasik
Hello 👋
Would you accept a PR that replaces webpack with Vite? It's a modern build tool that would make developer experience much better, it would also greatly reduce amount of dependencies and simplify the project setup. I did some initial tests and I was able to switch Maputnik to Vite fairly smoothly, here is the result: master...damianstasik:editor:replace-webpack-with-vite (just look at that
package-lock.json
reduction 🤩).I would love to contribute such a PR, but what are your thoughts on that?
The text was updated successfully, but these errors were encountered: