-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.3.0 #340
Comments
Awesome work on the accessibility, @orangemug! First thing from the browser console:
|
@gregorywolanski I think that's an existing bug in https://github.com/maputnik/editor/blob/4b5536b282cb97059fcbb181e2af01af37a2bc2f/src/components/App.jsx#L352 only for styles with mapbox data sources. Can you confirm that this was also an issue with the previous release? If so raise a new ticket and we'll fix for the next release |
@gregorywolanski I noticed one bug with the survey Comments (at the end of the survey) are a single line input should probably be multiline Also is it possible (and would you consider) putting a message on survey completion saying
|
I will do my best to take a look at this before the end of the week. At glance, I don’t see this same message in the console in the previous release.
Good point! Fixed.
I can’t change this part of the survey in the free version of Typeform. |
@gregorywolanski you're correct, the actual error is (printed as a warning a few lines above)
It looks like |
Fixed |
@pathmapper @keum Any feedback? :) |
Looks good to me, thanks! |
Released |
@orangemug sorry...didn't get a chance to test it out yet...will take a look tomorrow and will reply. thanks for everyone for the work you guys have put together. Also quick remark on documentation relating to issue #337 I could stab at contributing few things for sure. There staff here who also loves Maputnik, so we'll collaborate to the effort. thanks! |
No worries @keum, any feedback just create a new ticket now. I prioritised pushing the release since a few people had already given it a check over.
Awesome! Lets talk documentation over in #337 I've got a few ideas as well |
New release ready for testing at https://maputnik.github.io/releases/v1.3.0-beta
If anyone has time to give it a try, please report anything broken that wasn't broken in the previous version, or respond 'It looks good to me!'. CC @gregorywolanski @pathmapper @keum
I'll release the non-beta once people have given it a test.
Changes
<input>
's (Disable spellcheck on <input/>'s #304)<button>
s so they are keyboard accessible (Made buttons keyboard accessible #298)Contributions from @gregorywolanski @pathmapper @orangemug
The text was updated successfully, but these errors were encountered: