Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.0 #340

Closed
orangemug opened this issue Jul 11, 2018 · 11 comments
Closed

Release v1.3.0 #340

orangemug opened this issue Jul 11, 2018 · 11 comments

Comments

@orangemug
Copy link
Collaborator

New release ready for testing at https://maputnik.github.io/releases/v1.3.0-beta

If anyone has time to give it a try, please report anything broken that wasn't broken in the previous version, or respond 'It looks good to me!'. CC @gregorywolanski @pathmapper @keum

I'll release the non-beta once people have given it a test.

Changes

Contributions from @gregorywolanski @pathmapper @orangemug

@gregwolanski
Copy link
Contributor

gregwolanski commented Jul 11, 2018

Awesome work on the accessibility, @orangemug!

First thing from the browser console:

app.b31056cb1cf2efb150c4.js:19 Fetch API cannot load mapbox://mapbox.mapbox-streets-v7. URL scheme must be "http" or "https" for CORS request.

@orangemug
Copy link
Collaborator Author

@gregorywolanski I think that's an existing bug in https://github.com/maputnik/editor/blob/4b5536b282cb97059fcbb181e2af01af37a2bc2f/src/components/App.jsx#L352 only for styles with mapbox data sources.

Can you confirm that this was also an issue with the previous release? If so raise a new ticket and we'll fix for the next release

@orangemug
Copy link
Collaborator Author

orangemug commented Jul 11, 2018

@gregorywolanski I noticed one bug with the survey

Comments (at the end of the survey) are a single line input should probably be multiline

Also is it possible (and would you consider) putting a message on survey completion saying

If you appreciate Maputnik please consider donating

@gregwolanski
Copy link
Contributor

Can you confirm that this was also an issue with the previous release?

I will do my best to take a look at this before the end of the week.

At glance, I don’t see this same message in the console in the previous release.

Comments (at the end of the survey) are a single line input should probably be multiline

Good point! Fixed.

Also is it possible (and would you consider) putting a message on survey completion […]

I can’t change this part of the survey in the free version of Typeform.

@orangemug
Copy link
Collaborator Author

@gregorywolanski you're correct, the actual error is (printed as a warning a few lines above)

Failed to normalizeSourceURL: TypeError: Cannot read property 'normalizeSourceURL' of undefined

It looks like mapboxUtil.normalizeSourceURL no longer exists, see

https://github.com/maputnik/editor/blob/8b0aa194cfde3cb9d36be78a9013c8512ee9950c/src/components/App.jsx#L368

@orangemug
Copy link
Collaborator Author

orangemug commented Jul 12, 2018

Fixed mapboxUtil.normalizeSourceURL issue in #341. Nice spot @gregorywolanski

@gregwolanski
Copy link
Contributor

@pathmapper @keum Any feedback? :)

@pathmapper
Copy link
Contributor

Looks good to me, thanks!

@orangemug
Copy link
Collaborator Author

Released v1.3.0 all the places

@keum
Copy link

keum commented Jul 12, 2018

@orangemug sorry...didn't get a chance to test it out yet...will take a look tomorrow and will reply. thanks for everyone for the work you guys have put together. Also quick remark on documentation relating to issue #337 I could stab at contributing few things for sure. There staff here who also loves Maputnik, so we'll collaborate to the effort. thanks!

@orangemug
Copy link
Collaborator Author

sorry...didn't get a chance to test it out yet...will take a look tomorrow and will reply.

No worries @keum, any feedback just create a new ticket now. I prioritised pushing the release since a few people had already given it a check over.

Also quick remark on documentation relating to issue #337 I could stab at contributing few things for sure

Awesome! Lets talk documentation over in #337 I've got a few ideas as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants