Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node version to use from nvmrc file #437

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Fix node version to use from nvmrc file #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf65c7b
Update test-all.yml
HarelM Dec 4, 2023
9d8a3a7
Update build-docs.yml
HarelM Dec 4, 2023
53b9741
Update publish-style-spec.yml
HarelM Dec 4, 2023
87e9ed3
Update deploy-docs.yml
HarelM Dec 4, 2023
df7eb73
Update test-all.yml
HarelM Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 18
node-version-file: '.nvmrc'

- name: Install NPM packages
run: npm ci
Expand All @@ -26,4 +26,4 @@ jobs:
run: |
cd ./docs
npm ci
npm run build
npm run build
4 changes: 2 additions & 2 deletions .github/workflows/deploy-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 18
node-version-file: '.nvmrc'

- name: Install NPM packages
run: npm ci
Expand All @@ -32,4 +32,4 @@ jobs:
uses: JamesIves/github-pages-deploy-action@v4
with:
branch: gh-pages
folder: docs/dist/public
folder: docs/dist/public
5 changes: 2 additions & 3 deletions .github/workflows/publish-style-spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ jobs:
with:
fetch-depth: 0

- name: Use Node.js 18 x64
- name: Use Node.js from nvmrc
uses: actions/[email protected]
with:
node-version: 18
architecture: x64
node-version-file: '.nvmrc'
registry-url: 'https://registry.npmjs.org'

- name: Get version
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- run: npm ci
- run: npm run lint
if: success() || failure()
Expand All @@ -32,7 +32,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- run: npm ci
- run: npm run jest-ci -- --coverage --coverageDirectory=coverage-unit --coverageReporters json --selectProjects unit
- run: npm run jest-ci -- --coverage --coverageDirectory=coverage-integration --coverageReporters json --selectProjects integration
Expand All @@ -51,7 +51,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- run: npm ci
- run: npm run generate-style-spec
- run: npm run generate-typings
Expand Down