Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up default style specification #14

Closed
ianthetechie opened this issue Dec 19, 2022 · 1 comment
Closed

Clean up default style specification #14

ianthetechie opened this issue Dec 19, 2022 · 1 comment

Comments

@ianthetechie
Copy link
Collaborator

Upstream on iOS falls back to the MapLibre demo tiles. However, Android will crash with a random exception.

The Android framework currently also has a place in the OfflineManager where a default is defined. I currently address the exception issue above by importing this in another module, which is a bit of a code smell. It seems like we should probably just extract this elsewhere.
@ianthetechie ianthetechie changed the title Clean up default style definition Clean up default style specification Dec 19, 2022
@KiwiKilian
Copy link
Collaborator

Fixed through #559. The DEFAULT_STYLE_URL is now inside the MLRNModule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianthetechie @KiwiKilian