From d6f64f394e85422f2d7f3b17a0494dd90cbd8ea8 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Fri, 26 Jul 2024 14:24:03 -0700 Subject: [PATCH 1/2] Add reminder to add changelog entry to pull request template --- .github/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 49611625..15e60640 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,10 @@ -### Description - +### Checklist +- [ ] I added an entry to `CHANGELOG.md` if knowledge of this change could be valuable to users. +- [ ] I linked any relevant issues from https://github.com/maplibre/maplibre-navigation-ios/issues -### Open Tasks +### Description -- [ ] ### Infos for Reviewer From 256371f1102ce0be678411ff4354566c6ac60cb0 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Fri, 26 Jul 2024 14:38:19 -0700 Subject: [PATCH 2/2] Add missing changelog entries I didn't include everything from https://github.com/maplibre/maplibre-navigation-ios/pull/86/files In particular, I omitted things that were fixups to the unreleased "Start & Stop Navigation in existing Map" And things that were test fixes, changes to the readme, and otherwise more likely to be distracting than useful for the user to know about. --- CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dbfb3f38..60d01723 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ - To simulate a route, pass a `SimulatedLocationManager` to `startNavigation()` function: ```swift - #if targetEnvironment(simulator) + #if targetEnvironment(simulator) let locationManager = SimulatedLocationManager(route: route) locationManager.speedMultiplier = 2 self.startNavigation(with: route, animated: false, locationManager: locationManager) @@ -19,6 +19,10 @@ * Merged in * Updated "turf" geometry library from 0.2.2 to 2.8.0 * Merged in https://github.com/maplibre/maplibre-navigation-ios/pull/91 +* Only require background audio when using speech synthesis in https://github.com/maplibre/maplibre-navigation-ios/pull/64 +* Fix: Respond to changes in dynamic type without having to restart the app in https://github.com/maplibre/maplibre-navigation-ios/pull/65 +* Fix: crash in EndOfRouteViewController and restore its presentation by in https://github.com/maplibre/maplibre-navigation-ios/pull/71 +* Fix: retain cycles in RouteMapViewController ## 3.0.0 (Jun 15, 2024) * The `speak` method in `RouteVoiceController` can be used without a given `RouteProgress` or the `RouteProgress` can explicitly ignored so that it will not be added to the voice instruction.