crash when route ends: [Storyboard] Unknown class _TtC40maplibre-navigation-ios_MapboxNavigation13RatingControl in Interface Builder file. #57
Comments
michaelkirk
added a commit
to michaelkirk/maplibre-navigation-ios
that referenced
this issue
Jun 13, 2024
Previously, having voice instructions was a requirement of ending the route. Now we'll end the route when banner instructions are done *and* only consider voice instructions if there were any to begin with. Note: This currently crashes do to another issue with the end of route view controller: see maplibre#57
|
I pushed a fix to #58. |
|
I can separate them if there's a preference, but it's difficult for me to test one without the other. |
michaelkirk
added a commit
to michaelkirk/maplibre-navigation-ios
that referenced
this issue
Jun 14, 2024
Previously, having voice instructions was a requirement of ending the route. Now we'll end the route when banner instructions are done *and* only consider voice instructions if there were any to begin with. Note: This currently crashes do to another issue with the end of route view controller: see maplibre#57
michaelkirk
added a commit
to michaelkirk/maplibre-navigation-ios
that referenced
this issue
Jun 20, 2024
Previously, having voice instructions was a requirement of ending the route. Now we'll end the route when banner instructions are done *and* only consider voice instructions if there were any to begin with. Note: This currently crashes do to another issue with the end of route view controller: see maplibre#57
michaelkirk
added a commit
to michaelkirk/maplibre-navigation-ios
that referenced
this issue
Jun 24, 2024
FIXES maplibre#57 - by rewriting EORVC as programmatic VC rather than storyboard. FIXES maplibre#62 - Omitted the "Rate this route" feedback while rewriting the EORVC. Note this was cherry-picked, and no longer works due to change in maplibre#54
michaelkirk
added a commit
to michaelkirk/maplibre-navigation-ios
that referenced
this issue
Jun 27, 2024
FIXES maplibre#57 - by rewriting EORVC as programmatic VC rather than storyboard. FIXES maplibre#62 - Omitted the "Rate this route" feedback while rewriting the EORVC. Note this was cherry-picked, and no longer works due to change in maplibre#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to Trigger Behavior
Link to Minimal Reproducible Example
I don't have an example handy, but if you're interested I can put one together.
Expected Behavior
The endOfRouteViewController should be presented
Actual Behavior
The app crashes due to:
Screenshots (if applicable)
Version(s) affected
Additional context
One thing that confused me is that there seems to be another bug whereby the end of route logic will never fire unless you are using spoken directions, which I hadn't been. I'll open up an issue for that momentarily. (update - here it is: #58)
The text was updated successfully, but these errors were encountered: