Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping workflows not working as intended #1772

Closed
louwers opened this issue Oct 17, 2023 · 1 comment
Closed

Skipping workflows not working as intended #1772

louwers opened this issue Oct 17, 2023 · 1 comment
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@louwers
Copy link
Collaborator

louwers commented Oct 17, 2023 •
edited
Loading

A while back I added fkirc/skip-duplicate-actions because GitHub's way of preventing unnecessary workflow runs does not play well with required actions.

However, it seems that PR workflows are not being skipped when you branch off main while a workflow is still running for code that was just checked in. This is a known limitation: fkirc/skip-duplicate-actions#122

If you want to take advantage of skipping workflows when opening a PR, make sure to branch off a commits for which the workflows already ran.

Maybe it's worth it to look into another solution for preventing unneeded workflow runs though.
@louwers louwers added the github_actions Pull requests that update GitHub Actions code label Oct 17, 2023
@louwers
Copy link
Collaborator Author

louwers commented Oct 17, 2023

I am trying out https://github.com/tj-actions/changed-files now, I think it is a better fit.

@louwers louwers closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@louwers