Fonts with comma in filename break on CLI

[SvanteRichter]

Hello!

I was using the CLI to convert google fonts and it seems like it cannot handle files with commas like for example the upstream google font "NotoSans[wdth,wght].ttf". It seems like the web version works fine.

If I just rename the font to not include a comma it works.

Thanks!

How to reproduce

• Build the CLI
• Download a font with a comma in it (example: https://github.com/google/fonts/blob/main/ofl/notosans/NotoSans%5Bwdth%2Cwght%5D.ttf)
• Run font-maker ./font-maker --name "NotoSans" "./tmp" "./NotoSans[wdth,wght].ttf"
• Get the error:

Adding ./NotoSans[wdth
terminate called after throwing an instance of 'std::runtime_error'
  what():  Could not open font face
Aborted (core dumped)

Attachments

• Include the font file (.ttf or .otf) you are trying to convert.
  NotoSans[wdth,wght].zip

[bdon]

Looks like a limitation of cxxopts: jarro2783/cxxopts#228

You can add #define CXXOPTS_VECTOR_DELIMITER '\0' to the top of main.cpp as a workaround

Or maybe we should just require the input doesn't have commas?

[SvanteRichter]

I think it would be nice to have a specific error thrown/logged, I spent quite a while trying to figure out if my font was broken. On the other hand if I understand correctly the CLI is a bit semi-official, so maybe I'm just an outlier for both using the CLI and using the raw font names from google fonts.

Either way, thanks so much for the tool :)

[bdon]

Should be fixed in #39 , thanks.