[BUG] Adding an existing source causes app to crash

[albertmoravec]

Platforms

iOS

Version of flutter maplibre_gl

0.20.0

Bug Description

Calling controller.addSource() more than once for the same source causes app crash on iOS with MLNRedundantSourceIdentifierException.

Steps to Reproduce

1. Call controller.addSource('123', VectorSourceProperties(...)).
2. Call controller.addSource('123', VectorSourceProperties(...)) again with the same ID.

Expected Results

Exception should be returned.

Actual Results

App completely crashes with MLNRedundantSourceIdentifierException, not providing any option to handle the exception.

Code Sample

await controller.addSource('123', VectorSourceProperties());
await controller.addSource('123', VectorSourceProperties());

[albertmoravec]

Not sure if this can be fixed from Swift side, so I opened an issue on MapLibre Native.

[danieljosua1]

@albertmoravec I’ve also run into this issue multiple times – the same problem also occurs on Android

[Rossdex]

This was also an issue on the mapbox version of this plugin, any platform exceptions cause a full on app crash.

The solution I have been working with is to keep track of which layers you have added to your map in a provider and remove the layer and re-add with the new data. It's not ideal but it works and the performance hit isn't huge.

[ivanesi]

The solution I have been working with is to keep track of which layers you have added to your map in a provider and remove the layer and re-add with the new data. It's not ideal but it works and the performance hit isn't huge.

It should be fixed. In some cases even this will not help:

    final existingSources = await _getVehicleSourceIds();
    if (existingSources.contains(sourceId)) {
      _logger.warning('_addSource() existingSources contains $sourceId, do _setSource');
      await _setSource(sourceId, json);
      return;
    }

    await _mapController.addGeoJsonSource(sourceId, json);
    await _addCirclesLayer(sourceId);
    await _addNamesLayer(sourceId);
  }