Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Check for exact version matches during pre-release check #169

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Feb 1, 2024

Description

  • Fix release-pre-check CircleCI step to check for exact version matches (inside double-quotes) during pre-release check
  • The current behavior is failing for the 2.0.0 release because 2.0.0-alpha.1 is matching
  • This fix will correct the behavior by searching for "2.0.0" which will not match against "2.0.0-alpha.1"

Checklist

  • [N/A] Update CHANGELOG

@aokj4ck aokj4ck requested review from a team as code owners February 1, 2024 15:59
@aokj4ck aokj4ck requested a review from kried February 1, 2024 15:59
Copy link

@mapbox-danny mapbox-danny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@aokj4ck aokj4ck merged commit b779627 into main Feb 2, 2024
4 checks passed
@aokj4ck aokj4ck deleted the fix-pre-release-check branch February 2, 2024 19:32
aokj4ck added a commit that referenced this pull request Apr 5, 2024
…ease check (#169)

### Description

- Fix release-pre-check CircleCI step to check for exact version matches (inside double-quotes) during pre-release check
- The previous behavior would for any semvar release without a suffix if any suffix is published (ex: 2.0.0 fails because 2.0.0-alpha.1 is published)
- This fix will correct the behavior by searching for `"2.0.0"` which will not match against `"2.0.0-alpha.1"`

### Checklist
- [N/A] Update `CHANGELOG`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants