Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSDK-542] Update maki icons to SVG #155

Merged
merged 12 commits into from
Feb 8, 2024
Merged

[SSDK-542] Update maki icons to SVG #155

merged 12 commits into from
Feb 8, 2024

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Jan 23, 2024 •
edited
Loading

Description

Fixes SSDK-542

Checklist

  • Update nightclub icon
  • Update CHANGELOG

Screenshots

Previous custom icons Maki repo SVG icons
Simulator Screen Shot - iPhone 14 Plus - 2024-01-23 at 13 51 17 Simulator Screen Shot - iPhone 14 Plus - 2024-02-07 at 11 31 21

aokj4ck and others added 9 commits January 23, 2024 13:21
@aokj4ck
Update icon generation script for swiftlint and swiftformat complianc…
70dc11d 
…e - SSDK-542

- Generate latest assets with some changes and some additions
- All other file changes are binary noise
@aokj4ck
Remove all custom Maki icons, replace all with SVG - SSDK-542
57a7fe2
@aokj4ck
Update generate_maki script with fixes - SSDK-542
831b553 
- Remove development output
- Remove commends
- Fix contents.json
@aokj4ck
Fix generated code regarding documentation vs swiftformat comment - S…
8b813fc 
…SDK-542
@aokj4ck
Fix asset references for hotel/lodging, auto-repair/carRepair, and xc…
721c1e3 
…assetName field - SSDK-542
@aokj4ck
Update changelog - SSDK-542
280de9f
@aokj4ck
Merge branch 'main' into SSDK-542-update-maki-icons
3e3dba0
@aokj4ck
Merge branch 'main' of github.com:mapbox/mapbox-search-ios into SSDK-…
8e8af55 
…542-update-maki-icons

Conflicts:
	CHANGELOG.md
@aokj4ck
Manually add in-progress nightclub icon
545849d
@aokj4ck aokj4ck marked this pull request as ready for review February 6, 2024 22:59
@aokj4ck aokj4ck requested review from a team as code owners February 6, 2024 22:59
azarovalex
azarovalex previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@azarovalex azarovalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is SVG support on iOS 12, could you double check somehow it works there? 🤔

@aokj4ck
Copy link
Contributor Author

aokj4ck commented Feb 8, 2024

My only concern is SVG support on iOS 12, could you double check somehow it works there? 🤔

I might have to set up a virtual machine with an older macOS to run an older Xcode 😅 😓

@aokj4ck
Copy link
Contributor Author

aokj4ck commented Feb 8, 2024

My only concern is SVG support on iOS 12, could you double check somehow it works there? 🤔

I might have to set up a virtual machine with an older macOS to run an older Xcode 😅 😓

I looked into both options and found that A) I can't validate on iOS 12 unless we find an old iOS device or Mac and B) SVG support should be acceptable and backwards compatible, just that iOS 12 devices will use PNGs converted by Xcode. [https://sarunw.com/posts/svg-image-assets-supported-in-xcode12/, https://www.willowtreeapps.com/craft/what-svg-support-means-for-your-ios-app-graphics]

@aokj4ck aokj4ck merged commit 910b2d1 into main Feb 8, 2024
4 checks passed
@aokj4ck aokj4ck deleted the SSDK-542-update-maki-icons branch February 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azarovalex azarovalex azarovalex approved these changes

@mapbox-danny mapbox-danny Awaiting requested review from mapbox-danny mapbox-danny is a code owner automatically assigned from mapbox/search-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aokj4ck @azarovalex