Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Waypoint 'separatesLegs' flag not being applied during navigation #4725

Open
RL-William-Coates opened this issue Oct 2, 2024 · 3 comments
Labels
bug Something isn’t working

Comments

@RL-William-Coates
Copy link

Mapbox Navigation SDK version

3.3.1

Steps to reproduce

Create a multi-waypoint route with the map matching API, set 'separatesLegs' to false for all waypoints except the first and last. Start navigation.

Expected behavior

The voice instructions do not call out waypoints as destinations.

Actual behavior

The voice instructions are calling out waypoints as destinations.

As demonstrated by the screenshots below. Waypoint 2 is at the end of the road, and the voice instructions are calling it out as a destination. If I print out the step instructions of the route, waypoints are not being treated as destinations.

SCR-20241002-lpgt

SCR-20241002-lopi

Is this a one-time issue or a repeatable issue?

repeatable

@RL-William-Coates RL-William-Coates added the bug Something isn’t working label Oct 2, 2024
@kried
Copy link
Contributor

kried commented Oct 16, 2024

Hi @RL-William-Coates

We were unable to reproduce your problem. Both voice and visual instructions do not mention silent waypoints, also the problem does not repeat itself during reroutes.

Could you please share the history route file with us so we can investigate your specific route? You can record it using HistoryRecorder. There is a sample app using historyRecorder.

Or you can send us a sample app or code sample where you can reproduce the issue.

@RL-William-Coates
Copy link
Author

Hi @kried

Attached is a history replay of me reproducing the issue.

Also attached is a modified version of History-Recording.swift to help you reproduce the issue yourself. The main changes are in the userDidLongTap logic, and requestRoute() function. Simulate Navigation must be OFF. Here are some further instructions:

Set initial user location: 51.994726, -2.394331

Create first waypoint at: 51.998013, -2.379042
Create second waypoint at: 52.036780, -2.422791

Start navigation

Change user location to: 51.994930, -2.394601 (this needs to cause a rerouting event)
Change user location to: 51.994985, -2.393452 (this helps you get back on route)

Now both the voice and visual instructions treat the middle waypoint at the end of Beach lane as a destination. It even displays a waypoint marker on the map.

history_replay.gz
History-Recording.swift.zip

@kried
Copy link
Contributor

kried commented Oct 17, 2024

Thank you for the detailed report. We were able to reproduce the problem and pass it on to the corresponding Directions API team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

2 participants