Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localizeLabels() doesn't work for Standard & Satellite Map Styles #2243

Open
amzada opened this issue Sep 26, 2024 · 2 comments
Open

localizeLabels() doesn't work for Standard & Satellite Map Styles #2243

amzada opened this issue Sep 26, 2024 · 2 comments
Labels
bug 🪲 Something is broken!

Comments

@amzada
Copy link

amzada commented Sep 26, 2024

Environment

  • Xcode version: 16.0
  • iOS version: 17.0
  • Devices affected: Tested on iPhone 15 & iPhone 13 Pro
  • Maps SDK Version: 11.6.0

Observed behavior and steps to reproduce

Calling localizeLabels() does not localize labels for standard and new satellite map style. Does however work for custom map styles + traffic map style

Expected behavior

Calling localizeLabels() should localize labels for all map styles

Notes / preliminary analysis

internal func convertExpressionForLocalization called as part of localizeLabels() returns nil

Additional links and references

@amzada amzada added the bug 🪲 Something is broken! label Sep 26, 2024
hlongngo pushed a commit to hlongngo/mapbox-maps-ios that referenced this issue Sep 29, 2024
@jvanderwee
Copy link

Hey @pjleonard37 👋 could you please take a look at this one?

@pjleonard37
Copy link
Contributor

Hi all --

Mapbox Standard introduced a new basemap approach that changed how layers are handled at runtime. As you've identified, this means that the localizeLabels() approach to translating map labels does not work for these styles.

We're working on a different approach to translating map labels for Standard and Standard Satellite and hope to share additional information soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something is broken!
Projects
None yet
Development

No branches or pull requests

3 participants