Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🦟 Bug] Use of Directions.url(forCalculating options: DirectionsOptions, httpMethod: String) -> URL causes crash #444

Open
misterkerry opened this issue Aug 11, 2020 · 4 comments
Labels

Comments

@misterkerry
Copy link

Problem

When using this method resulting URL is normally delivered. But, on occasion the method crashes causing the App leveraging the SDK to crash.

Environment

These crashes are shown in Organizer:

Screen Shot 2020-08-11 at 6 47 59 PM

Recommendation

Line 410, 411, 413 shows 3 forced unwrapped objects that could be part of the problem:
These elements can be guarded or error messages send to the App

let unparameterizedURL = URL(string: includesQuery ? options.path : options.abridgedPath, relativeTo: credentials.host)!

@misterkerry
Copy link
Author

cc: @1ec5 @zugaldia

@zugaldia
Copy link
Member

Thanks for the report @misterkerry - do you have any logs that may include parameter values that would help us reliably reproduce this issue?

/cc: @chezzdev

@misterkerry
Copy link
Author

misterkerry commented Aug 13, 2020

No problem @zugaldia . The link to the Crashlytics log above and will take a user to the logs in firebase. I would have to give access to the investigator.
I can also put a file in an access-only directory. lmk.

@1ec5
Copy link
Contributor

1ec5 commented Aug 21, 2020

Line 410, 411, 413 shows 3 forced unwrapped objects that could be part of the problem

Force-unwrapping here essentially asserts that the URL is a well-formed URL. That most likely means something about the API hostname or query parameters is malformed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants