Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to globally fit peaks to calculate shared parameters #59

Open
3 of 7 tasks
MialLewis opened this issue Apr 24, 2023 · 3 comments
Open
3 of 7 tasks

Add ability to globally fit peaks to calculate shared parameters #59

MialLewis opened this issue Apr 24, 2023 · 3 comments

Comments

@MialLewis
Copy link
Collaborator

MialLewis commented Apr 24, 2023

We want to add the ability to globally fit peaks to calculate shared parameters.

For this stage of the project, the following sub-issues need to be resolved:

  • Add ability to globally fit peaks
  • Add calculation of E1 value with globally fitted peaks.
  • Add calculation of L1 value with globally fitted peaks
  • Add ability to specify whether peaks should be individually fit, globally fit, or both.
  • Add ability to manually specify invalid detectors, instead of using the function.
  • Refactor global fitting capability to reduce code reuse where possibe.
  • Increase unit test coverage of new global fitting capability.
@MialLewis
Copy link
Collaborator Author

I'm working on Add ability to manually specify invalid detectors, instead of using the function.

@jess-farmer
Copy link
Collaborator

I've been working on Add ability to specify whether peaks should be individually fit, globally fit, or both. - I'll open a PR with these changes later today

@MialLewis
Copy link
Collaborator Author

I've been working on Add ability to specify whether peaks should be individually fit, globally fit, or both. - I'll open a PR with these changes later today

To warn, there's quite a big PR #61 in bound that will separate the calibration script file so that the two different classes are held in different files.

I suspect this PR will be merged before yours, so it may be worth rebasing on the associated branch sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants