Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _roi_ranges from SpectrumViewerWindowModel #2415

Open
ashleymeigh2 opened this issue Nov 25, 2024 · 2 comments
Open

Remove _roi_ranges from SpectrumViewerWindowModel #2415

ashleymeigh2 opened this issue Nov 25, 2024 · 2 comments
Assignees

Comments

@ashleymeigh2
Copy link
Collaborator

The _roi_ranges dictionary in SpectrumViewerWindowModel creates unnecessary complexity and synchronization issues with the SpectrumWidget's own ROI dictionary. Recent updates, such as enabling get_spectrum() to accept SensibleROI, have reduced the need for the model to maintain its own list of ROIs.

Desired Behaviour

The _roi_ranges attribute is fully removed, and all dependent methods are refactored out.

Current Behaviour

SpectrumViewerWindowModel maintains a _roi_ranges dictionary for mapping ROI names to ranges.
This requires constant synchronization with the ROI dictionary in SpectrumWidget, leading to redundancy and potential issues.

@ashleymeigh2
Copy link
Collaborator Author

@ashleymeigh2
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant