Incorrect knn search by doc id

[Nick-S-2018]

Bug Description:

Now the knn doc id search test is failing in the php client, which may relate to the recent changes made in #417
@donhardman, can you please check if this is really the case?

Here are the responses for the same http request received from the dev and last release versions, respectively:

curl localhost:9308/search -d '{"index":"test","knn":{"field":"test_vector","doc_id":3,"k":5}}'
{"took":9,"timed_out":false,"hits":{"total":6,"total_relation":"eq","hits":[{"_id":4,"_score":1,"_knn_dist":0.050000,"_source":{"test_vector":[0.300000,0.500000]}},{"_id":5,"_score":1,"_knn_dist":0.130000,"_source":{"test_vector":[0.500000,0.500000]}},{"_id":2,"_score":1,"_knn_dist":0.160000,"_source":{"test_vector":[0.200000,0.300000]}},{"_id":6,"_score":1,"_knn_dist":0.500000,"_source":{"test_vector":[0.700000,0.200000]}},{"_id":10,"_score":1,"_knn_dist":0.530000,"_source":{"test_vector":[0.900000,0.900000]}}]}}

curl localhost:9308/search -d '{"index":"test","knn":{"field":"test_vector","doc_id":3,"k":5}}'
{"took":130,"timed_out":false,"hits":{"total":6,"total_relation":"eq","hits":[{"_id":3,"_score":1,"_knn_dist":0.000000,"_source":{"test_vector":[0.200000,0.700000]}},{"_id":4,"_score":1,"_knn_dist":0.05000000,"_source":{"test_vector":[0.300000,0.500000]}},{"_id":5,"_score":1,"_knn_dist":0.130000,"_source":{"test_vector":[0.500000,0.500000]}},{"_id":2,"_score":1,"_knn_dist":0.15999998,"_source":{"test_vector":[0.200000,0.300000]}},{"_id":6,"_score":1,"_knn_dist":0.500000,"_source":{"test_vector":[0.700000,0.200000]}},{"_id":10,"_score":1,"_knn_dist":0.530000,"_source":{"test_vector":[0.900000,0.900000]}}]}

A test table can be created with:

create table test ( test_vector float_vector knn_type='hnsw' knn_dims='2' hnsw_similarity='l2' );
insert into test values ( 2, (0.2,0.3) ), ( 3, (0.2,0.7) ), ( 4, (0.3,0.5) ), ( 5, (0.5,0.5) ), ( 6, (0.7,0.2) ), ( 10, (0.9,0.9) );

Manticore Search Version:

dev

Operating System Version:

Ubuntu 22.04 LTS

Have you tried the latest development version?

None

Internal Checklist:

^{To be completed by the assignee. Check off tasks that have been completed or are not applicable.}

• Implementation completed
• Tests developed
• Documentation updated
• Documentation reviewed
• Changelog updated

[donhardman]

Fix implemented: #433

[donhardman]

Please let me know if it fixes the issue

[Nick-S-2018]

Yes, the issue is fixed now.