Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vtt Cue settings are parsed as new lines #64

Closed
vnali opened this issue Jun 22, 2023 · 2 comments
Closed

Vtt Cue settings are parsed as new lines #64

vnali opened this issue Jun 22, 2023 · 2 comments

Comments

@vnali
Copy link
Contributor

vnali commented Jun 22, 2023

For vtt subtitles, the Cue settings are added to the right of the cue timings like:
00:00:05.000 --> 00:00:10.000 line:63% position:72% align:start

The problem is when fileContentToInternalFormat of vttConverter parse $file_content via preg_match_all, it adds these settings as new lines.

Is it possible if fix for this issue does not remove this cue settings when generating internal format and keep it in internal format somehow? -maybe destination format is vtt again and we load subtitle only for adding new lines and we want new subtitle back as vtt again.

i totally understand that you have limited time as you mentioned here,
-to be clear, i am not asking if this class should do something about cue setting saved in internal format, only let us as developer to process it later-

@mantas-done
Copy link
Owner

@vnali Hi, if you want, you can add a $internal_format['vtt_settings'] variable that would hold styles. No other class would use this variable except VttConverter when generating again VTT file.
If you would make such changes, I would merge them.
(I hope I understood the problem correctly)

@vnali
Copy link
Contributor Author

vnali commented Jul 18, 2023

Thanks @mantas-done
I can see there are new commits and open PRs related to the vtt parsing. i will test it on the new tag and check how changes affect vtt parsing and see if i am able to make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants