Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump ini from 1.3.5 to 1.3.7 #1064

Closed
wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps ini from 1.3.5 to 1.3.7. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Prototype Pollution

Overview

The ini npm package before version 1.3.6 has a Prototype Pollution vulnerability.

If an attacker submits a malicious INI file to an application that parses it with ini.parse, they will pollute the prototype on the application. This can be exploited further depending on the context.

Patches

This has been patched in 1.3.6

Steps to reproduce

payload.ini

[__proto__]
polluted = "polluted"

poc.js:

var fs = require('fs')
</tr></table> ... (truncated)

Affected versions: < 1.3.6

Commits
  • c74c8af 1.3.7
  • 024b8b5 update deps, add linting
  • 032fbaf Use Object.create(null) to avoid default object property hazards
  • 2da9039 1.3.6
  • cfea636 better git push script, before publish instead of after
  • 56d2805 do not allow invalid hazardous string as section name
  • See full diff in compare view
Maintainer changes

This version was pushed to npm by isaacs, a new releaser for ini since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request during working hours.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview dependabot-preview bot requested a review from a team as a code owner December 10, 2020 17:41
@dependabot-preview dependabot-preview bot requested review from clwiseman and removed request for a team December 10, 2020 17:41
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Dec 10, 2020
@vercel
Copy link

vercel bot commented Dec 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/manifold/ui/e9vfbbnr3
✅ Preview: https://ui-git-dependabot-npmandyarnini-137.manifold.vercel.app

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #1064 (524df5e) into master (0c9fa08) will decrease coverage by 0.64%.
The diff coverage is 86.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
- Coverage   79.46%   78.82%   -0.65%     
==========================================
  Files          81       80       -1     
  Lines        1534     1577      +43     
  Branches      394      356      -38     
==========================================
+ Hits         1219     1243      +24     
- Misses        281      304      +23     
+ Partials       34       30       -4     
Impacted Files Coverage Δ
...ld-data-provision-button/create-with-owner.graphql 100.00% <ø> (ø)
src/data/resource.tsx 75.00% <ø> (ø)
src/utils/marketplace.ts 42.85% <ø> (+5.35%) ⬆️
...d-data-has-resource/manifold-data-has-resource.tsx 79.48% <42.85%> (ø)
...ifold-data-sso-button/manifold-data-sso-button.tsx 86.20% <50.00%> (-0.46%) ⬇️
...urce-credentials/manifold-resource-credentials.tsx 92.30% <50.00%> (ø)
.../manifold-resource-list/manifold-resource-list.tsx 78.57% <60.00%> (-0.92%) ⬇️
...resource-container/manifold-resource-container.tsx 86.48% <75.00%> (-4.69%) ⬇️
src/global/app.ts 65.71% <78.84%> (ø)
...ents/manifold-active-plan/manifold-active-plan.tsx 59.09% <100.00%> (+2.56%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c62b31...524df5e. Read the comment docs.

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot-preview
Copy link
Contributor Author

Superseded by #1065.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/ini-1.3.7 branch December 14, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants