Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom favicon, colorscheme #3

Open
hyperreal64 opened this issue Dec 10, 2023 · 1 comment
Open

Support custom favicon, colorscheme #3

hyperreal64 opened this issue Dec 10, 2023 · 1 comment
Assignees

Comments

@hyperreal64
Copy link

hyperreal64 commented Dec 10, 2023

This is an amazing theme! Thanks for making it.

I'm wondering if you could support setting a custom favicon in config.toml.

If it's not too much trouble, would you be willing to support changing the colorscheme in config.toml? If this add more complexity than necessary/desired, then don't worry about it.

@manid2 manid2 self-assigned this Dec 11, 2023
@manid2
Copy link
Owner

manid2 commented Dec 12, 2023

Hi @hyperreal64 thanks for appreciating this theme 😃 .

I made this for my own personal website. I have added all the (minimal) features I needed in my website to show my CV, blogs and technical documentation.

Regarding your queries:

support setting a custom favicon in config.toml.

This is already present in this theme we can set any image as favicon in config.toml at this location config.toml:13

favicon = "/images/xterm.png"

If this is not what you want please let me know what you are expecting so I can support it.

support changing the colorscheme

This is simple to implement in this theme we just need to change the base HSL color from this all other colors are derived.

Here is how this theme looks if I change the base color blue HSL(240deg, 100%, 50%) to red HSL(0deg, 100%, 50%).

image

But some parts of the theme may not be readable or not clearly visible so need to adjust the base color and check visually for every component in the theme so this is a lot of effort for now will do it at some point later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants