Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joust] Crash on RequestRespawn & ArmorEmpty events when having 1 armor #7

Open
ProfessorLaw opened this issue Mar 15, 2020 · 1 comment · May be fixed by #8
Open

[Joust] Crash on RequestRespawn & ArmorEmpty events when having 1 armor #7

ProfessorLaw opened this issue Mar 15, 2020 · 1 comment · May be fixed by #8

Comments

@ProfessorLaw
Copy link

Hello there !

On Joust script, a crash will happen if the player is having only 1 armor and triggers the OnArmorEmpty or OnPlayerRequestRespawn (falls into offzone or press backspace). This is because JoustRespawnPlayer function is called with an Armor parameter set to 0 in that case.

Screenshots :
image

image

I will include a patch proposal soon.

Thank you !
@ProfessorLaw ProfessorLaw linked a pull request Mar 15, 2020 that will close this issue
Open
@ProfessorLaw
Copy link
Author

@Aessi Here's my patch proposal, in case you might want to use it ! :)
Have a nice day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Joust - Fix crashes when trying to respawn a player with 0 armor ProfessorLaw/game-modes
1 participant
@ProfessorLaw