Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ida.plugin.diaphora.vm: Install it as an IDA plugin #994

Closed
Ana06 opened this issue Apr 16, 2024 · 4 comments · Fixed by #1069
Closed

ida.plugin.diaphora.vm: Install it as an IDA plugin #994

Ana06 opened this issue Apr 16, 2024 · 4 comments · Fixed by #1069
Assignees
Labels
👩‍🦱 IDA Related to IDA or an IDA plugin 🌀 FLARE-VM A package or feature to be used by FLARE-VM ❔ discussion Further discussion is needed 🆕 package New package request/idea/PR

Comments

@Ana06
Copy link
Member

Ana06 commented Apr 16, 2024

Details

ida.diaphora.vm is just copying the diaphora script to the Utilities folder. From discussions I had with users, I get the impression that diaphora is not being noticed and that it would be much useful if we would install it as a plugin as we do in ida.plugin.capa.vm and rename it as ida.plugin.diaphora.vm.

@Ana06 Ana06 added ❔ discussion Further discussion is needed 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Apr 16, 2024
@Ana06 Ana06 self-assigned this Apr 16, 2024
@Ana06
Copy link
Member Author

Ana06 commented Apr 16, 2024

I'll explore how difficullt this is. diaphora does not support installation as a plugin.

@emtuls
Copy link
Member

emtuls commented Apr 16, 2024

I think it's a great plugin! Would be nice to have it installed properly if possible. Thank you for looking into it!

@Ana06 Ana06 added the 👩‍🦱 IDA Related to IDA or an IDA plugin label May 7, 2024
@Ana06
Copy link
Member Author

Ana06 commented May 13, 2024

I have explored writing a plugin file to wrap the script. The issue is to run the diaphora code with the current project structure, as it is not a Python module. Making the project a Python module would only imply changing the imports in diaphora to be prepended by diaphora.. After that, coping the diaphora plugin file and the diaphora Python module folder (similar to how we do with the flare module in ida.plugin.flare.vm would install diaphora as a plugin. So taking this into account, I think we should ask upstream if they would be up to supporting installing diaphora as a plugin and see if we can help.

@Ana06
Copy link
Member Author

Ana06 commented May 21, 2024

diaphora has now plugin support: joxeankoret/diaphora#301 🎉 Waiting for the release to make the change in VM-Packages 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍🦱 IDA Related to IDA or an IDA plugin 🌀 FLARE-VM A package or feature to be used by FLARE-VM ❔ discussion Further discussion is needed 🆕 package New package request/idea/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants