Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename fiddlerclassic.vm to fiddler.vm #985

Closed
Ana06 opened this issue Apr 11, 2024 · 1 comment · Fixed by #1006
Closed

rename fiddlerclassic.vm to fiddler.vm #985

Ana06 opened this issue Apr 11, 2024 · 1 comment · Fixed by #1006
Assignees
@Ana06
Labels
🐛 bug Something isn't working 🌀 COMMANDO-VM A package or future to be used by COMMANDO VM

Comments

@Ana06
Copy link
Member

Ana06 commented Apr 11, 2024

Details

fiddlerclassic.vm version is not being currently updated correctly by our bot because it does not follow our documentation. We should rename the package to fiddler.vm so that the dependency and the package have the same name and our CI updates its version as a metapackage. Any objection in doing this change @mandiant/commando-vm?

Related: #972
@Ana06 Ana06 added 🐛 bug Something isn't working 🌀 COMMANDO-VM A package or future to be used by COMMANDO VM labels Apr 11, 2024
@Ana06 Ana06 self-assigned this Apr 11, 2024
@geo-lit
Copy link
Contributor

geo-lit commented Apr 11, 2024

No objection @Ana06

This was referenced Apr 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ana06 Ana06

Labels
🐛 bug Something isn't working 🌀 COMMANDO-VM A package or future to be used by COMMANDO VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fiddler.vm] Follow metapackage documentation Ana06/VM-Packages
2 participants
@Ana06 @geo-lit