Do not allow bot to overwrite someone else changes

[Ana06]

Details

We should add a --force-with-lease to our bot to avoid that it overwrites someone else changes when updating packages like in #864 (comment)

[mr-tz]

or we can create unique branches including the date here:

VM-Packages/.github/workflows/update_package.yml

Line 64 in 201a848

branch: package-update

[Ana06]

@mr-tz

or we can create unique branches including the date here:

This will create several updates PRs, which I don't think it is desirable. The bot at the moment overwrites its own changes adding more updates and removing broken owns if the PR is not merged within a week or if triggered manually. I think this is a nice feature we want to keep. If we modified manually the PR, it is because there is an issue, so we don't want the bot to send another broken PR.

[Ana06]

I think we should ensure that the bot pushes using --force-with-lease. Not sure if this a bug or a feature request in https://github.com/peter-evans/create-pull-request

[Ana06]

I have open an issue at peter-evans/create-pull-request#2766

[Ana06]

The bot is already using --force-with-lease (see peter-evans/create-pull-request#2766). I think we should close this issue, as we would have to lose some nice feature to ensure the bot does not change the PR. I think it is not worthwhile, as this has only happened once and we can ensure we merge quick when manually modifying bot PR or push the changes to a new PR.

[Ana06]

We could at least improve the comment in the PR to help people reviewing the changes that may not be familiar with the automation.