Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share installer code from FLARE-VM and commando-vm in VM-Packages #687

Open
Ana06 opened this issue Oct 12, 2023 · 1 comment
Open

Share installer code from FLARE-VM and commando-vm in VM-Packages #687

Ana06 opened this issue Oct 12, 2023 · 1 comment
Labels
🌀 COMMANDO-VM A package or future to be used by COMMANDO VM 🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better

Comments

@Ana06
Copy link
Member

Ana06 commented Oct 12, 2023

The installer of FLARE-VM and commando-vm have a lot similar code. When we improve of fix a bug in one of the projects, this is not shared with the other. Remove this duplication by adding a file in vm-packages that is not a package persay, but a flat .psm1 file that we can download on the fly from both installers. This file will contain function with functionality like the checks before installing or the way we install boxstarter/choco.

Then we get the following logical divide:

  • If it needs to be shared across packages, update common.vm
  • If it needs to be shared for the installer, update that flat .psm1 file in vm-packages (maybe name it shared_installer.psm1 or something)
@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM 🌀 COMMANDO-VM A package or future to be used by COMMANDO VM labels Oct 12, 2023
@Ana06 Ana06 assigned Ana06 and unassigned Ana06 Oct 12, 2023
@Ana06
Copy link
Member Author

Ana06 commented Oct 20, 2023

See #708 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌀 COMMANDO-VM A package or future to be used by COMMANDO VM 🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ana06