Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Removal of map.vm Right Click "Cmd Here" option from "map.vm" to "windows-terminal.vm" #1002

Open
emtuls opened this issue Apr 19, 2024 · 0 comments
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed

Comments

@emtuls
Copy link
Member

emtuls commented Apr 19, 2024

Details

As of #983, we opted to remove the right click "Cmd Here" that map.vm introduces when installing due to favoring the right click for opening with Windows Terminal instead.

But, we placed this removal code inside of the map.vm package, which means that if a user wants map.vm and wants to retain this right click option, but does not add windows-terminal.vm to their list of packages, they would have no Right Click "Cmd Here" option available to them automatically.

I think the removal of the Right Click "Cmd Here" added by map.vm is better suited inside of the windows-terminal.vm package, as that is where we are essentially replacing the right click option, and would give uses the ability to keep the one added by map.vm if they wanted to only use that package.

@emtuls emtuls added 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed
Projects
None yet
Development

No branches or pull requests

1 participant