From 78dc4fde3d1fd34f24b71f3f827a96dcd071b449 Mon Sep 17 00:00:00 2001
From: Elliot Chernofsky <35854880+emtuls@users.noreply.github.com>
Date: Tue, 30 Jan 2024 18:40:51 -0500
Subject: [PATCH] Remove Windows Terminal testing on windows-2019

---
 .github/workflows/ci.yml | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index ca23b7dd8..b080ab97a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -38,9 +38,16 @@ jobs:
       - name: Build and test all modified packages
         id: test
         # It runs only if there are modified files
+        # We specifically test for "microsoft-windows-terminal.vm" in 'windows-2019' because it requires at least Windows 10 version 1903/OS build 18362
+        # The "test_install.ps1" script will fail if attempting to pass a NULL package list
         if: steps.files.outputs.added_modified_renamed != ''
         run: |
+          $os = "${{ matrix.os }}"
           $packages = "${{ steps.files.outputs.added_modified_renamed }}".Split(" ") | Foreach-Object { (Get-Item $_).Directory.Name }
+          if ($os -eq 'windows-2019') {
+            $packageToRemove = "microsoft-windows-terminal.vm"
+            $packages = $packages -replace $packageToRemove, ""
+          }
           scripts/test/test_install.ps1 "common.vm $packages"
       - name: Upload logs to artifacts
         uses: ./.github/actions/upload-logs
@@ -48,7 +55,7 @@ jobs:
       - name: Push all built packages to MyGet
         # Only push packages on master if they were built (not if testing was skipped) and
         # only with one version of Windows (otherwise it would be pushed 3 times)
-        if: steps.test.outcome == 'success' && github.event_name == 'push' && matrix.os == 'windows-2019'
+        if: steps.test.outcome == 'success' && github.event_name == 'push' && matrix.os == 'windows-2022'
         run: |
           $built_pkgs = Get-ChildItem built_pkgs
           Set-Location built_pkgs