Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel execution of token approvals #52

Open
ghost opened this issue Dec 8, 2017 · 0 comments
Open

Parallel execution of token approvals #52

ghost opened this issue Dec 8, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Dec 8, 2017

Some contracts (e.g. Tub) need multiple approvals in order to be able to work, whereas some other ones (e.g. SimpleMarket) often need to be approved to access multiple tokens. It gets even more complex if a 'TxManager` is involved.

Unfortunately token approvals are sequential right now i.e. the keepers wait for the each previous approval to get mined before they send a next one. It means that the whole process can easily take 5-10 minutes.

Would be nice to be able to send multiple approvals in parallel, the same way it can be done with transact_async() for regular transactions.

It's not a high-priority task as approvals only happen the first time we start a keeper, so it's not such a big deal to wait these 5-10 minutes.

@ghost ghost added the enhancement label Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants