Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade transaction successfulness detection after the Byzantium fork #47

Open
ghost opened this issue Nov 14, 2017 · 0 comments
Open

Comments

@ghost
Copy link

ghost commented Nov 14, 2017

The Byzantium fork added a status field to the transaction receipt, which tells us whether the transaction was successful or failed.

Having said that, currently the keeper determines transaction status by checking if the transaction logged any event or not. I guess we can safely replace it by just checking that status field, as we already fetch the receipt anyway.

@ghost ghost added the enhancement label Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants