Streaming JSON parser, helper for streaming arrays of small values #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregstuder
commented
Oct 20, 2016
| @@ -7,6 +7,10 @@ | |||
|
|
|||
| VALGRIND_CMD = 'valgrind --tool=memcheck --leak-check=yes --undef-value-errors=yes' | |||
|
|
|||
| # Hack for OSX el capitan and above | |||
| if "TEST_DYLD_LIBRARY_PATH" in os.environ: | |||
There was a problem hiding this comment.
FYI - the fix here is that with OSX's bad new SIP in el capitan+, anything executed from /usr/bin (i.e. /usr/bin/env) has DYLD_LIBRARY_PATH stripped.
|
2 bugs - forgot an include, and always need to initialize the error value to something Now fully blue on jenkins. |
|
Should probably also bump the minor version if this goes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to do some I/O to/from JSON of intermediate toolpather artifacts (like 2D+Z chunks, raw motion information, etc.) - this will create big JSON arrays, which currently can't be read efficiently with json-cpp.
This patch rewires the Reader implementation to use an iterator interface that looks identical to char* iteration - no change to behavior, but now it's possible to stream parse arrays (and other stuff too in the future if we want).