Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "dithering" behavior #266

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Mar 9, 2012

  1. Added a (failing) test to demonstrate dithering.

    The Makerbot-derived printer drivers contain a math error that
    manifests several different ways: Z-hold unexpectedly engaged during
    a print; wobbles on otherwise straight edges; increased loss of
    steps (including Z steps) during rapid motion, as in fills.
    
    This test case demonstrates the bug.  The next commit fixes it.
    cbiffle committed Mar 9, 2012
    Configuration menu
    Copy the full SHA
    32b246d View commit details
    Browse the repository at this point in the history
  2. Removed the excess-tracking code from the drivers.

    This fixes the dithering problem; the Makerbot4GAlternateDriverTest
    now passes.
    cbiffle committed Mar 9, 2012
    Configuration menu
    Copy the full SHA
    cab13a4 View commit details
    Browse the repository at this point in the history
  3. Fixed compilation errors in MachineLoaderTest.

    Which, incidentally, doesn't pass.
    cbiffle committed Mar 9, 2012
    Configuration menu
    Copy the full SHA
    3cfb577 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c01bd8d View commit details
    Browse the repository at this point in the history
  5. Fixed incorrect override that disabled stepper fan.

    I've added @OverRide annotations to all overrides.  This revealed
    a bug: the enableMotor/disableMotor, despite being documented as
    overrides, weren't.  As a result, the Sanguino3GDriver behavior
    was being invoked, generating DC motor control messages even when
    the axis has been hijacked for a stepper extruder.  Because this
    driver reuses the same motor control channel for the stepper fan,
    this meant the fan turned on...until the first motion.  Then it
    started toggling on and off with the stepper motor.
    
    That's kind of silly, so with this change it obeys the flag passed
    to enableStepperExtruderFan(boolean).
    cbiffle committed Mar 9, 2012
    Configuration menu
    Copy the full SHA
    45dc178 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2012

  1. Configuration menu
    Copy the full SHA
    24e3cca View commit details
    Browse the repository at this point in the history