Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix: s6-svc: fatal: unable to control /services/rsyslogd #70

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

AndrewSav
Copy link
Collaborator

@AndrewSav AndrewSav commented Dec 16, 2024

Description

There seem to be a race condition that prevents mailserver starting on some machines. There is a disucssion in the linked issue.

Fixes #68

This PR adds a small delay for _parent process so s6-supervise has time to start for other processes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Status

  • Ready

Todo List

  • Implementation
  • Tests
  • Documentation

How has this been tested ?

I ran docker compose up -d --force-recreate before that change 5 times. Failed 4 times out five. I ran it 5 times after the change it succeded all 5 times.

Copy link
Member

@SaraSmiseth SaraSmiseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSav AndrewSav merged commit 8cb6ee2 into mailserver2:master Dec 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s6 service issue on start up after down/up or restart of the mailserver container
2 participants