-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Course editing is buggy #28
Comments
@Ascent817 The contents of the card don't change back because we completely mess up React's handling of the DOM. Honestly, we should revamp this with the modal/form you suggested earlier. |
I agree. I'm leaning towards a modal, especially since you already implemented one. What do you think? |
It's a good idea. We really should refactor things so they're more reusable (dynamic components, better CSS, etc.). I often copy and paste code from other elements to have the same style. |
Btw, we need to be able to store login info longer term, I find it annoying that it completely resets and we have to login again after a page reload. |
Store with cookies? |
I think so. Then we need cookie warning lol :) |
We would be the only people getting cookies lol |
I feel like we should rerender the DOM after clicking Cancel, though that would be a performance hit hmm. |
This likely needs to be fixed for teachers/admin |
The text was updated successfully, but these errors were encountered: