New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product Reviews] Fix pagination #462

Open

magento-engcom-team opened this issue Dec 10, 2020 · 1 comment

Labels

Progress: backlog

magento-engcom-team commented Dec 10, 2020 •

edited by mslabko

Loading

During iteration product reviews the last element should return "null" for cursor value.

Steps to reproduce:

Create 2 approved product reviews
Start iterate over reviews with pagination size "1"
call ProductReviews.getProductReviews method with gRPC UI
with received cursor value from the previous call send new request to getProductReviews

Expected results:

after 2nd call, cursor should have "null" value

Actual result:

cursor is not null, send request with given cursor value to getProductReviews will return empty result

repo: https://github.com/magento/storefront-product-reviews-ce/

magento-engcom-team added the Progress: backlog label

Author

magento-engcom-team commented Dec 10, 2020

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-179

m2-community-project bot added Progress: in grooming and removed Progress: backlog labels

mslabko changed the title ~~Pagination improvement~~ [Product Reviews] Fix pagination

github-jira-sync-bot added Progress: ready for grooming and removed Progress: in grooming labels

github-jira-sync-bot added Progress: backlog and removed Progress: ready for grooming labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment