Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to product variants. #418

Open
bricht opened this issue Nov 10, 2020 · 3 comments
Open

Add pagination to product variants. #418

bricht opened this issue Nov 10, 2020 · 3 comments

Comments

@bricht
Copy link
Contributor

bricht commented Nov 10, 2020

Need to add pagination to product variants and remove current cap of 5000 variants per request.

Modify the GetProductVariants service and the elasticsearch query logic to support pagination.

service VariantSearchService {
    rpc GetProductVariants (ProductVariantRequest) returns (ProductVariantResponse);
}```

See Magento\StorefrontStorage\Model\Client\ElasticsearchQuery
@m2-assistant
Copy link

m2-assistant bot commented Nov 10, 2020

Hi @bricht. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@mslabko
Copy link
Member

mslabko commented Feb 10, 2021

@magento export issue to Jira project SFAPP as Story

@github-jira-sync-bot
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/SFAPP-313) is successfully created for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants