Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an ability to the Magento backend users (merchants) to set up country restrictions separately for each AlphaCommerceHub's payment option (bank cards, PayPal, POLi Payments, etc.) #85

Open
dmitrii-fediuk opened this issue Dec 13, 2017 · 4 comments

Comments

@dmitrii-fediuk
Copy link
Member

dmitrii-fediuk commented Dec 13, 2017

Similar to #84 (Provide an ability to the Magento backend users (merchants) to set up the «Require the billing address?» option separately for each AlphaCommerceHub's payment option (bank cards, PayPal, POLi Payments, etc.))

@dmitrii-fediuk
Copy link
Member Author

dmitrii-fediuk commented Dec 13, 2017

It would be nice to implement mage2pro/core#62 first (Improve Magento\Payment\Model\Checks\CanUseForCountry\CountryProvider::getCountry(): it should give priority to the shipping country over the billing country for my modules).

dmitrii-fediuk added a commit that referenced this issue Dec 13, 2017
@dmitrii-fediuk
Copy link
Member Author

Implemented in 0.7.4.

@dmitrii-fediuk
Copy link
Member Author

Currently, it does not work correctly if a shipping address is changed without the browser's page reload, because the following code is not executed in this case:
https://github.com/mage2pro/alphacommercehub/blob/0.7.5/view/frontend/web/loader.js#L11-L12

@dmitrii-fediuk
Copy link
Member Author

As I understand, I can just pass the country restriction rules from the server side to the customer's browser, and adjust the payment options visibility dynamically in JavaScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant