Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Run integration tests w/o Rabbitmq #14

Open
damienwebdev opened this issue Apr 25, 2023 · 1 comment
Open

[FEAT] Run integration tests w/o Rabbitmq #14

damienwebdev opened this issue Apr 25, 2023 · 1 comment

Comments

@damienwebdev
Copy link
Member

💡 Feature request

Feature Name

The Desired Behavior

I never saw integration tests that depend on RabbitMQ. Since there is a way to install Magento w/o it - I think it's a good idea to speed up the integration test.

Currently, I'm not using these actions because of this.
here is my config preparation for integration tests:

      - name: Replace Configuration Settings for env
        working-directory: ./magento2/dev/tests/integration/etc
        run: |
          cat install-config-mysql.php.dist \
            | sed "s/'db-host' => 'localhost'/'db-host' => '127.0.0.1'/" \
            | sed "s/'db-user' => 'root'/'db-user' => 'user'/" \
            | sed "s/'db-password' => '123123q'/'db-password' => 'password'/" \
            | sed "s/'elasticsearch-host' => 'localhost'/'elasticsearch-host' => '127.0.0.1'/" \
            | sed '/amqp/d' > install-config-mysql.php

Your Use Case

Prior Work

Environment


Magento version: X.Y.Z 
PHP Version version: X.Y.Z 


Others:

cc: @ihor-sviziev

Copied from graycoreio/github-actions-magento2#64

@gowrizrh
Copy link
Member

gowrizrh commented Aug 14, 2023

i think integration tests that depend on RabbitMQ are rarer 😉 but it is definitely worth having it.

there could be a flag that optionally enables rmq. but i don't really see how disabling rmq would speed up integration tests though.

here's an example that needs rabbitmq in integration tests.

https://github.com/mage-os/mageos-async-events/blob/3.x/Test/Integration/EventRetryTest.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants