Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build mimir from source for F-Droid #325

Open
maelchiotti opened this issue Dec 21, 2024 · 8 comments · May be fixed by #339
Open

Build mimir from source for F-Droid #325

maelchiotti opened this issue Dec 21, 2024 · 8 comments · May be fixed by #339
Assignees
Labels
release New release

Comments

@maelchiotti
Copy link
Owner

maelchiotti commented Dec 21, 2024

Hi @linsui. I've added the build of flutter_mimir to my pipeline. It simply calls fdroid_build_mimir.sh, which build the binaries and moves them to the pub cache, pretty much like with isar.

The only thing that seems a bit weird to me is that when building the APK during my testing, Flutter installed an NDK for some reason, while it did not previously. So I hope it still uses the one I set up before 🤔

Do you need me do to anything to make sure the F-Droid build works correctly? I'm making a new release today but if anything needs to be changed I'll make a new one during the week.

@maelchiotti maelchiotti self-assigned this Dec 21, 2024
@maelchiotti maelchiotti added the release New release label Dec 21, 2024
@maelchiotti maelchiotti moved this to In progress in LocalMaterialNotes Dec 21, 2024
@linsui
Copy link

linsui commented Dec 22, 2024

It simply calls fdroid_build_mimir.sh, which build the binaries and moves them to the pub cache, pretty much like with isar.

Thanks, testing... Could you please make it build only 1 abi? And [this command] should use --locked so that it won't suddenly break if a dep releases a new version.

The only thing that seems a bit weird to me is that when building the APK during my testing, Flutter installed an NDK for some reason, while it did not previously. So I hope it still uses the one I set up before 🤔

Is this fixed? I saw your issues and the related commits which seems to be related to this.

@maelchiotti
Copy link
Owner Author

I'll take a look at what you asked, but you forgot the link for the command I should --locked.

And I don't think the NDK issue is fixed, the v1.10.0 also has it. I'm wondering if something in the mimir build process triggers the installation, I don't really know.

@linsui
Copy link

linsui commented Dec 22, 2024

Ah, https://github.com/GregoryConrad/mimir/blob/c00cdd195fc11ef9e9af64d85e607411e792e316/scripts/build-android.sh#L13 this line. :)

ndkVersion flutter.ndkVersion
Not sure which version this is. Maybe you can set it to r26d?

@linsui
Copy link

linsui commented Dec 23, 2024

It builds.

@maelchiotti
Copy link
Owner Author

Great, and it's reproducible?

@linsui
Copy link

linsui commented Dec 23, 2024

Yes, it's reproducible. :)

@maelchiotti
Copy link
Owner Author

Well, awesome! So I guess the weird NDK install doesn't mess with the APK in the end.

@linsui
Copy link

linsui commented Dec 23, 2024

Not sure. Maybe it mess with the apk reproducibly. :) It's older than r26d so it's not likely used by chance anyway.

@maelchiotti maelchiotti linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release New release
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants