Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthBackend#login() tries to log in passively regardless of the value of the passive option #92

Open
DmitrySharabin opened this issue Jun 27, 2024 · 0 comments
Milestone

Comments

@DmitrySharabin
Copy link
Member

DmitrySharabin commented Jun 27, 2024

The default value of the passive option is false:

async login ({passive = false, ...rest} = {}) {

So, Madata shouldn't try to log in passively. However, it does, regardless:

await this.passiveLogin(rest);

This means that backend.login() and (even worse) backend.login({ passive: false }) will throw for every backend that hasn't implemented passiveLogin() even if this backend isn't meant to log the user in passively (e.g., for security reasons).

@DmitrySharabin DmitrySharabin added this to the Public launch milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant