Trie log fixes for madara #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the trie log. There were a bunch of issues with lifetimes that wouldn't work with madara.
By fixing it, I temporarily a bunch of features that we don't yet use. (merging transactions, some flat db stuff I believe, and uncomitted transactional storage features in general) I don't expect us to add them back to be honest, I am planning on refactoring the whole trie-log anyway and they will probably not be ported.
In the meantime this pull request breaks a bunch of stuff, but that's okay since the bonsai-trie doesn't have any other consumer than madara as far as I know.